On 2025/4/22 23:59, Jan Beulich wrote:
> On 21.04.2025 08:18, Jiqian Chen wrote:
>> Modify function pci_find_next_cap_ttl to support returning position
>> of next capability when size "n" is zero.
>>
>> That can help caller to get next capability offset if caller just
>> has a information of current capability offset.
>>
>> That will be used in a follow-on change.
>>
>> Signed-off-by: Jiqian Chen <[email protected]>
>
> Acked-by: Jan Beulich <[email protected]>
Thank you.
> albeit ...
>
>> --- a/xen/drivers/pci/pci.c
>> +++ b/xen/drivers/pci/pci.c
>> @@ -55,6 +55,9 @@ unsigned int pci_find_next_cap_ttl(pci_sbdf_t sbdf,
>> unsigned int pos,
>>
>> if ( id == 0xff )
>> break;
>> + if ( n == 0 )
>> + return pos;
>> + ASSERT(caps);
>> for ( i = 0; i < n; i++ )
>> {
>> if ( id == caps[i] )
>
> ... blank lines around you insertion might have been nice. I may take the
> liberty of adding them while committing.
That's fine, please add.
>
> Jan
--
Best regards,
Jiqian Chen.
