On 16/04/2025 12:48 am, Stefano Stabellini wrote:
>> diff --git a/automation/scripts/qubes-x86-64.sh
>> b/automation/scripts/qubes-x86-64.sh
>> index c4be71464246..e2376cb51cb4 100755
>> --- a/automation/scripts/qubes-x86-64.sh
>> +++ b/automation/scripts/qubes-x86-64.sh
>> @@ -164,16 +164,13 @@ ${domU_extra_config}
>> "
>>
>> if [ -n "$domU_check" ]; then
>> - # DomU
>> + # DomU rootfs
>> + cp binaries/rootfs.cpio.gz binaries/domU-rootfs.cpio.gz
>> +
>> + # test-local configuration
>> mkdir -p rootfs
>> cd rootfs
>> - # fakeroot is needed to preserve device nodes in rootless podman
>> container
>> - fakeroot -s ../fakeroot-save tar xzf ../binaries/initrd.tar.gz
>> - mkdir proc
>> - mkdir run
>> - mkdir srv
>> - mkdir sys
>> - rm var/run
>> + mkdir -p etc/local.d
>> echo "#!/bin/sh
> I am worried about the drop of fakeroot because the newly created dirs
> and files we'll have user as owner instead of root.
>
> I suggest we fix this for consistency, and cpio -R 0:0 might suffice.
https://gitlab.com/xen-project/hardware/xen-staging/-/jobs/9737393986#L1087
It seems to be all root anyway. I'm not entirely sure why, but it does
explain why everything is working, given the attempt to have non-root
containers.
~Andrew
