On 10/04/2025 2:51 pm, Anthony PERARD wrote:
> On Thu, Apr 10, 2025 at 12:46:27PM +0100, Andrew Cooper wrote:
>> diff --git a/images/alpine/3.18-arm64-build.dockerfile
>> b/images/alpine/3.18-arm64-build.dockerfile
>> new file mode 100644
>> index 000000000000..b6d9bd1af531
>> --- /dev/null
>> +++ b/images/alpine/3.18-arm64-build.dockerfile
>> @@ -0,0 +1,27 @@
>> +# syntax=docker/dockerfile:1
>> +FROM --platform=linux/arm64/v8 alpine:3.18
>> +LABEL maintainer.name="The Xen Project" \
>> + maintainer.email="[email protected]"
> I though we were repeating the "LABEL" on each line these days, to avoid
> the backslash at the end of the line. ;-)
Oh right. I'll fix.
>
>> +
>> +RUN apk --no-cache add bash
>> +
>> +RUN bash -ex <<EOF
>> + adduser -D user --shell bash
>> +
>> + DEPS=(# Base environment
>> + build-base
>> + curl
>> +
>> + # Linux build deps
>> + bison
>> + findutils
>> + flex
>> + openssl-dev
>> + perl
>> + )
>> +
>> + apk add --no-cache "\${DEPS[@]}"
> If I take one example from xen.git, we don't escape the $ and it's just
> "${DEPS[@]}", is it because the script is run with:
>
> RUN bash -ex <<EOF
>
> instead of
>
> RUN <<EOF
> #!/usr/bin/bash
>
> ?
>
>
> As for the rest of the patch, it looks fine to me. I don't know if the
> change to the build config are necessary but they looks fine.
Ah, I meant to look at that and forgot. This was started from the x86
container already in test-artefacts.
But yes, we want to do this the way xen.git does, with a set -eu too.
>
> With the LABEL repeated on each line:
> Reviewed-by: Anthony PERARD <[email protected]>
Thanks.
~Andrew
