On 08.04.2025 18:07, Alejandro Vallejo wrote:
> From: "Daniel P. Smith" <[email protected]>
>
> Introduce the `cpus` property, named as such for dom0less compatibility, that
> represents the maximum number of vpcus to allocate for a domain. In the device
Nit: vcpus
> --- a/xen/arch/x86/domain-builder/fdt.c
> +++ b/xen/arch/x86/domain-builder/fdt.c
> @@ -246,6 +246,17 @@ static int __init process_domain_node(
> bd->max_pages = PFN_DOWN(kb * SZ_1K);
> printk(" max memory: %ld kb\n", kb);
> }
> + else if ( strncmp(prop_name, "cpus", name_len) == 0 )
> + {
> + uint32_t val = UINT_MAX;
> + if ( fdt_prop_as_u32(prop, &val) != 0 )
And again the same nit.
> + {
> + printk(" failed processing max_vcpus for domain %s\n",
> name);
There's no "max_vcpus" being processed here; that purely ...
> + return -EINVAL;
> + }
> + bd->max_vcpus = val;
... the internal name we use for the struct field etc. The user observing the
message ought to be able to easily associate it back with the DT item.
Jan
