On 07/04/2025 1:31 pm, Marek Marczykowski-Górecki wrote:
> diff --git a/automation/scripts/console.exp b/automation/scripts/console.exp
> index 31ce97b91b63..d1689fa5bf7f 100755
> --- a/automation/scripts/console.exp
> +++ b/automation/scripts/console.exp
> @@ -28,21 +28,34 @@ if {[info exists env(UBOOT_CMD)]} {
> send "$env(UBOOT_CMD)\r"
> }
>
> +if {[info exists env(BOOT_MSG)]} {
> + expect -re "$env(BOOT_MSG)"
> +}
We're gaining an increasingly complex set of environment variables to
control this script. In particular, this is more a signs-of-life
message than a completion.
I think this patch wants splitting into two. First doing the -re
changes, and adding BOOT_MSG, and some comments explaining how each part
is supposed to be used. I expect the xilinx- jobs want to use BOOT_MSG
too, whereas I expect we don't want the qemu/cirrus smoke tests to use
it, seeing as they're all direct-boot in qemu.
The, the second patch is converting qubes-x86-64.sh to use it, adding
WAKEUP_CMD/SYSPEND_MSG as they're pretty specific.
~Andrew
