On 01.04.2025 15:08, Roger Pau Monne wrote:
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -63,6 +63,7 @@ SECTIONS
> . = __image_base__;
> /DISCARD/ : {
> *(.text.header)
> + *(.init.multiboot)
> }
> #endif
>
> @@ -208,6 +209,7 @@ SECTIONS
> _sinittext = .;
> *(.init.text)
> *(.text.startup)
> + *(.init.multiboot)
> _einittext = .;
Better keep stuff that was early in .init.text early, by putting
.init.multiboot first here? Then in principle:
Reviewed-by: Jan Beulich <[email protected]>
However, there are then-orphan contributions to .init.rodata (maybe also
to .init.data), which is at least a little odd. If they're to stay that
way at least for the moment, maybe at least mention the aspect as known
in the commit message?
Jan