On 06.03.2025 09:39, Penny Zheng wrote:
> +static const struct cpufreq_driver __initconst_cf_clobber
> +amd_cppc_cpufreq_driver =
> +{
> + .name = XEN_AMD_CPPC_DRIVER_NAME,
> +};
Because of the hook pointers not being set right here, ...
> +int __init amd_cppc_register_driver(void)
> +{
> + int ret;
> +
> + if ( !cpu_has_cppc )
> + {
> + xen_processor_pmbits &= ~XEN_PROCESSOR_PM_CPPC;
> + return -ENODEV;
> + }
> +
> + ret = cpufreq_register_driver(&amd_cppc_cpufreq_driver);
> + if ( ret )
> + return ret;
... this - afaict - will fail up until patch 09. This may want mentioning
in the description here. (Initially I thought you'd leave NULL derefs around
for several patches, until I checked cpufreq_register_driver().)
Jan
