On 12.03.2025 05:06, Penny Zheng wrote:
> This commit fixes return type of online_page(), which shall be int
> to include correct error value.
>
> Signed-off-by: Penny Zheng <[email protected]>
While the patch can certainly be taken as-is, ...
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1764,7 +1764,7 @@ int offline_page(mfn_t mfn, int broken, uint32_t
> *status)
> * The caller should make sure end_pfn <= max_page,
> * if not, expand_pages() should be called prior to online_page().
> */
> -unsigned int online_page(mfn_t mfn, uint32_t *status)
> +int online_page(mfn_t mfn, uint32_t *status)
> {
> unsigned long x, nx, y;
> struct page_info *pg;
... below here we have
ret = *status = 0;
which aiui will need splitting for Misra anyway. Perhaps a good opportunity
to do so right here? (I wouldn't mind doing the extra change while committing.
Yet I can also see that this may be deemed too orthogonal to the main purpose
of the change here.)
Jan
