>>> +static inline int iommu_domain_init(struct domain *d, unsigned int opts)
>>> +{
>>> + return 0;
>>
>> Shouldn't this fail when is_iommu_enabled(d) is true? (The use of the
>> predicate here as well as in the real function is slightly strange, but
>> that's the way it is.)
>
> Right, probably you know better this code than me, I started from the
> assumption
> that when !HAS_PASSTHROUGH, 'iommu_enabled' is false.
>
> is_iommu_enabled(d) checks if the domain structure ‘options’ field has
> XEN_DOMCTL_CDF_iommu, this flag is set on domain creation when ‘iommu_enabled'
> is true on arm and x86.
>
> So when !HAS_PASSTHROUGH can we assume is_iommu_enabled(d) give false?
> Or shall we return for example the value of is_iommu_enabled(d)?
Sorry, just a clarification here, I don’t mean return the value of
is_iommu_enabled straight away,
but use this to compute the return value of the stub.
Cheers,
Luca
