On 06.02.2025 16:06, Roger Pau Monne wrote:
> Add a new hook to inhibit interrupt generation by the IOMMU(s). Note the
> hook is currently only implemented for x86 IOMMUs.
Yet then ...
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -663,6 +663,12 @@ void iommu_crash_shutdown(void)
> #endif
> }
>
> +void iommu_quiesce(void)
> +{
> + if ( iommu_enabled )
> + iommu_vcall(iommu_get_ops(), quiesce);
> +}
..., with this being in common code, the function wants checking that the
pointer
to be called through isn't NULL.
As to the use on the crash path - iommu_crash_shutdown() was called a few lines
earlier. Why would we still need iommu_quiesce() there?
Jan
