On 06.02.2025 13:29, Jan Beulich wrote: > On 05.02.2025 22:02, Shawn Anastasio wrote: >> Xen's memory management APIs map_pages_to_xen, modify_xen_mappings, >> set_fixmap, ioremap_attr, and __vmap all use an unsigned int to >> represent architecture-dependent page table entry flags. This assumption >> is not well-suited for PPC/radix where some flags go past 32-bits, so >> introduce the pte_attr_t type to allow architectures to opt in to larger >> types to store PTE flags. >> >> Suggested-by: Andrew Cooper <[email protected]> >> Signed-off-by: Shawn Anastasio <[email protected]> >> --- >> Changes in v2: >> - Drop Kconfig option and use `#define pte_attr_t pte_attr_t` for arches to >> opt-in to defining the type. >> - Move default pte_attr_definition to xen/types.h > > I'm unconvinced of types.h being an appropriate place for something mm- > related. mm-types.h maybe?
To add to this (in an attempt to keep you from introducing a header of this name, just to then include it from types.h): I don't think this type wants exposing to all CUs. Ones entirely unrelated to mm (take e.g. everything that's under lib/) shouldn't get to see it. Jan
