On Tue Feb 4, 2025 at 3:07 PM GMT, Jan Beulich wrote: > On 04.02.2025 15:45, Alejandro Vallejo wrote: > > --- a/tools/firmware/hvmloader/config.h > > +++ b/tools/firmware/hvmloader/config.h > > @@ -48,8 +48,9 @@ extern uint8_t ioapic_version; > > > > #define IOAPIC_ID 0x01 > > > > +extern uint32_t *cpu_to_apicid; > > Strictly speaking this ought to be part of the earlier patch. If hvmloader > was Misra-checked, this would be a (transient) violation.
Hmmm. I don't see it. The previous patch is fully contained in smp.c and this extern isn't required until now. Does MISRA have mandates on non-static symbols not present in headers? The global could be static in patch1, but seems silly seeing how it'd be undone here. > > config.h is also somewhat odd a place to put this declaration, yet then I > can't really suggest anything better. > > Jan Any header will do but there's no better one I could find, and I'd rather not create a new one just for this. Cheers, Alejandro
