On 04.01.2025 02:58, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin <[email protected]> > > Add separate menu for configuring HVM build-time settings to help organizing > HVM-specific options. > > Signed-off-by: Denis Mukhin <[email protected]>
Largely: Why not. Question is whether what is being moved now may eventually require moving back, if support was extended to PV (MEM_PAGING and MEM_SHARING). That doesn't look very likely though. > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -30,7 +30,6 @@ config X86 > select HAS_SCHED_GRANULARITY > select HAS_UBSAN > select HAS_VMAP > - select HAS_VPCI if HVM > select NEEDS_LIBELF I don't mind the movement of this line, but I'd like to point out that it may be beneficial to have all selects of HAS_* in a central place. Views of other maintainers (or of course anyone else) appreciated. > --- /dev/null > +++ b/xen/arch/x86/hvm/Kconfig > @@ -0,0 +1,74 @@ > +menuconfig HVM > + bool "HVM support" > + depends on !PV_SHIM_EXCLUSIVE > + default !PV_SHIM > + select COMPAT > + select IOREQ_SERVER > + select MEM_ACCESS_ALWAYS_ON > + select HAS_VPCI We strive to have such lists of selects sorted alphabetically, preventing everyone to add to the end of the list (in turn reducing the risk of patches conflicting). Jan
