On 04.01.2025 02:58, Denis Mukhin via B4 Relay wrote:
> +domid_t console_get_owner(void)
> +{
> + return console_owner;
> +}
> +
> +/*
> + * Switch console input focus.
> + * Rotates input focus among Xen, dom0 and boot-time created domUs while
> + * skipping switching serial input to non existing domains.
> + */
> +static void console_switch_input(void)
I'm afraid I'm irritated now: In the earlier patch you said you renamed
console_rx to console_owner because that's not just about input. Yet
here you actively _add_ "input" to a comment that you've moved an re-
worded some.
> @@ -1149,8 +1144,8 @@ void __init console_endboot(void)
> register_irq_keyhandler('G', &do_toggle_guest,
> "toggle host/guest log level adjustment", 0);
>
> - /* Serial input is directed to DOM0 by default. */
> - console_switch_input();
> + if ( opt_conswitch[1] != 'x' )
> + console_set_owner( get_initial_domain_id() );
Nit: No blanks like this inside the parentheses of a function call,
please.
Jan
