On 08.01.2025 00:30, Stefano Stabellini wrote: > On Tue, 7 Jan 2025, Jan Beulich wrote: >> On 06.01.2025 22:36, Stefano Stabellini wrote: >>> xen: update pvcalls_front_accept prototype >>> >>> Signed-off-by: Stefano Stabellini <[email protected]> >>> --- >>> >>> Changes in v2: >>> - also update pvcalls-front.c >> >> The patch still gives the impression of being incomplete: There's no >> caller of the function that you update. However, there's no such caller >> in the first place. Why don't you just delete the function then? > > It is meant to be called from an out-of-tree module, which has not been > upstreamed yet
And which then would require an EXPORT_SYMBOL() anyway. In Xen, as you're well aware, such unreachable code would actually constitute a Misra violation. Without any in-tree caller, imo the change needs a non-empty description, clarifying why the adjustment is wanted / needed. Jan
