Hi,

> On 18 Dec 2024, at 15:09, Ayan Kumar Halder <[email protected]> wrote:
> 
> Hi Bertrand/Michal,
> 
> On 18/12/2024 14:00, Bertrand Marquis wrote:
>> Hi Michal,
>> 
>>> On 18 Dec 2024, at 14:56, Michal Orzel <[email protected]> wrote:
>>> 
>>> 
>>> 
>>> On 18/12/2024 14:08, Bertrand Marquis wrote:
>>>> 
>>>> Hi Ayan,
>>>> 
>>>>> On 18 Dec 2024, at 12:34, Ayan Kumar Halder <[email protected]> wrote:
>>>>> 
>>>>> 
>>>>> On 18/12/2024 08:27, Bertrand Marquis wrote:
>>>>>> Hi Ayan,
>>>>> Hi Bertrand,
>>>>>>> On 12 Dec 2024, at 20:03, Ayan Kumar Halder <[email protected]> 
>>>>>>> wrote:
>>>>>>> 
>>>>>>> From: Michal Orzel <[email protected]>
>>>>>>> 
>>>>>>> Add requirements for dom0less domain creation.
>>>>>>> 
>>>>>>> Signed-off-by: Michal Orzel <[email protected]>
>>>>>>> Signed-off-by: Ayan Kumar Halder <[email protected]>
>>>>>>> ---
>>> [...]
>>> 
>>>>>>> +SPIs
>>>>>>> +----
>>>>>>> +
>>>>>>> +`XenSwdgn~spis~1`
>>>>>>> +
>>>>>>> +Description:
>>>>>>> +Xen shall allocate a specified number of shared peripheral interrupts 
>>>>>>> for a
>>>>>>> +domain.
>>>>>> This is very ambiguous. What do you mean here ?
>>>>> Xen shall provide a way to specify the number of shared peripheral 
>>>>> interrupts for a domain via the device tree .
>>>> I am lost in how you achieve such a thing in the configuration.
>>>> All you can do is assigned an interrupt to a domain, but the sharing part 
>>>> I do not see what Xen has to do with it.
>>> This req is about Arm's SPIs (Shared Peripheral Interrupts) and the max 
>>> number you can allocate to a domU.
>>> You can see more here:
>>> https://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=docs/misc/arm/device-tree/booting.txt;hb=HEAD#l172
>> Oh right, no idea how i came to shared interrupts instead of Arm SPIs.
>> 
>> Then this is Arm specific and we need to have a bit more context/clear up 
>> here (as comment or introduction).
>> And also this should have arm64 somewhere.
> 
> ok, I can add Arm specific bits in the comments. Also, will put arm64 in the 
> tag.
> 
> Thinking again, this should be a product requirement as it explains the 
> interface to Xen (in this case a dt property), Is this correct understanding ?

Yes it should.

> 
> Also, to your other comment :-
> 
>>> I start to wonder if we should create interface requirements from the guest 
>>> PoV:
> 
>>> A domain shall have a configurable number of vCPUs (1 to XX).
> 
> This should be a product requirement as well. Correct ?

Correct.

Cheers
Bertrand

> 
> - Ayan



Reply via email to