On 17.12.2024 09:20, Chen, Jiqian wrote:
> On 2024/12/16 18:24, Roger Pau Monné wrote:
>> On Fri, Dec 13, 2024 at 01:42:32PM +0800, Jiqian Chen wrote:
>>> + if ( !is_hardware_domain(pdev->domain) )
>>> + {
>>> + printk("ReBar is not supported for domUs\n");
>>
>> This needs a bit more information IMO:
>>
>> printk(XENLOG_ERR
>> "%pd %pp: resizable BAR capability not supported for unprivileged
>> domains\n",
>> pdev->domain, &pdev->sbdf);
> OK, will change.
> If the length of code of printing more than 80 characters in one line, is it
> fine?
Technically: Yes. Imo in such cases one ought to strive though to shorten
wording as much as possible, without losing information. E.g. in this case
possibly:
printk(XENLOG_ERR
"%pp: resizable BARs unsupported for unpriv %pd\n",
&pdev->sbdf, pdev->domain);
Jan
