Re: [PATCH v2 4/7] xen/riscv: add {set,clear}_fixmap() functions for managing fixmap entries

[Jan Beulich]

On 11.12.2024 18:27, Oleksii Kurochko wrote:
> @@ -433,3 +434,19 @@ int __init populate_pt_range(unsigned long virt, 
> unsigned long nr_mfns)
>  {
>      return pt_update(virt, INVALID_MFN, nr_mfns, PTE_POPULATE);
>  }
> +
> +/* Map a 4k page in a fixmap entry */
> +void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags)
> +{
> +    if ( map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags | PTE_SMALL) != 0 )
> +        BUG();
> +}
> +
> +/* Remove a mapping from a fixmap entry */
> +void clear_fixmap(unsigned int map)
> +{
> +    if ( destroy_xen_mappings(
> +            FIXMAP_ADDR(map),
> +            FIXMAP_ADDR(map) + PAGE_SIZE) != 0 )

There are multiple options of how to indent such wrapped lines in function
invocations, but this isn't one of them.

    if ( destroy_xen_mappings(
             FIXMAP_ADDR(map),
             FIXMAP_ADDR(map) + PAGE_SIZE) != 0 )

(arguments offset by 4 from the function name, which may not be a multiple
of 4 from the start of the line) or

    if ( destroy_xen_mappings(FIXMAP_ADDR(map),
                              FIXMAP_ADDR(map) + PAGE_SIZE) != 0 )

Jan