On 15.11.2024 14:27, Andrew Cooper wrote: > Eclair reports a violation of MISRA Rule 5.3. > > get_stub() has a local ptr variable which genuinely shadows x86_emul_rmw()'s > parameter of the same name. The logic is correct, so the easiest fix is to > rename one of variables. > > With this addressed, Rule 5.3 is clean, so mark it as such. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> # x86 Albeit you certainly know ... > --- a/xen/arch/x86/x86_emulate/private.h > +++ b/xen/arch/x86/x86_emulate/private.h > @@ -672,19 +672,19 @@ amd_like(const struct x86_emulate_ctxt *ctxt) > # include <asm/uaccess.h> > > # define get_stub(stb) ({ \ > - void *ptr; \ > + void *_ptr; \ ... what I think of non-file-scope variable names starting with an underscore. Jan
