On 10/28/24 05:18, Andrew Cooper wrote:
There's no need for microcode_init_cache() to be called exactly where it is in
__start_xen(). All that matters is it must be after xmalloc() is available
and before APs start up.
As a consequence, microcode_init_cache() runs a little later on boot now.
No functional change.
Signed-off-by: Andrew Cooper <[email protected]>
---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Daniel P. Smith <[email protected]>
---
xen/arch/x86/cpu/microcode/core.c | 4 +++-
xen/arch/x86/include/asm/microcode.h | 1 -
xen/arch/x86/setup.c | 2 --
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/cpu/microcode/core.c
b/xen/arch/x86/cpu/microcode/core.c
index 8d916d891e6e..9a2cc631d2aa 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -819,8 +819,9 @@ static int __init early_update_cache(const void *data,
size_t len)
return rc;
}
-int __init microcode_init_cache(struct boot_info *bi)
+static int __init cf_check microcode_init_cache(void)
{
+ struct boot_info *bi = &xen_boot_info;
For context, the current function definition didn't have *bi const
because it will become necessary later update state in bi. So it is
natural for it to remain as such by getting the reference from global.
Reviewed-by: Daniel P. Smith <[email protected]>
