On 24.10.2024 15:22, Andrew Cooper wrote:
> The microcode suffix is redundant, and "microcode loading" is the more common
> term
Just to mention it - much like the microcode suffix is redundant, ...
> --- a/xen/arch/x86/cpu/microcode/amd.c
> +++ b/xen/arch/x86/cpu/microcode/amd.c
> @@ -214,8 +214,8 @@ static enum microcode_match_result cf_check compare_patch(
> return compare_header(new, old);
> }
>
> -static int cf_check apply_microcode(const struct microcode_patch *patch,
> - unsigned int flags)
> +static int cf_check amd_ucode_load(const struct microcode_patch *patch,
> + unsigned int flags)
> {
... the ucode infix is as well. Arguably even the amd prefix is redundant
(with the file name). I won't insist on either adjustment, though.
Jan
