On 06.10.2024 23:49, Daniel P. Smith wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -285,6 +285,9 @@ static struct boot_info __init
> *multiboot_fill_boot_info(unsigned long mbi_p)
>
> bi->nr_modules = (mbi->flags & MBI_MODULES) ? mbi->mods_count : 0;
>
> + bi->loader = (mbi->flags & MBI_LOADERNAME) ?
> + __va(mbi->boot_loader_name) : "unknown";
Either (noting that generally we exempt ?: from the operator-on-earlier-line
rule)
bi->loader = (mbi->flags & MBI_LOADERNAME) ? __va(mbi->boot_loader_name)
: "unknown";
or
bi->loader = (mbi->flags & MBI_LOADERNAME)
? __va(mbi->boot_loader_name) : "unknown";
or
bi->loader = (mbi->flags & MBI_LOADERNAME)
? __va(mbi->boot_loader_name) : "unknown";
(in the order of my personal preference).
Jan
