>>> On 29.06.18 at 15:52, <[email protected]> wrote: > On 29/06/18 14:10, Jan Beulich wrote: >> Also mark command line parsing routine __init. >> >> Signed-off-by: Jan Beulich <[email protected]> >> --- >> For credit2 I'm not sure the relatively verbose logging of all >> parameters should really happen upon every initialization. Otoh emitting >> it at boot time when the scheduler isn't actually used may also be >> confusing. >> >> --- a/xen/common/sched_credit.c >> +++ b/xen/common/sched_credit.c >> @@ -2156,6 +2156,36 @@ csched_dump(const struct scheduler *ops) >> spin_unlock_irqrestore(&prv->lock, flags); >> } >> >> +static int __init >> +csched_global_init(void) >> +{ >> + if ( sched_credit_tslice_ms > XEN_SYSCTL_CSCHED_TSLICE_MAX >> + || sched_credit_tslice_ms < XEN_SYSCTL_CSCHED_TSLICE_MIN ) > > Mind fixing the style to > > if ( sched_credit_tslice_ms > XEN_SYSCTL_CSCHED_TSLICE_MAX || > sched_credit_tslice_ms < XEN_SYSCTL_CSCHED_TSLICE_MIN ) > > as you're moving it?
Oh, sure - I should have noticed this myself. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
