On 30/09/2024 4:09 pm, Jan Beulich wrote: > There's no point using alternative_io() when there are no outputs. > > No functional change. > > Signed-off-by: Jan Beulich <[email protected]> > > --- a/xen/arch/x86/flushtlb.c > +++ b/xen/arch/x86/flushtlb.c > @@ -286,11 +286,10 @@ void cache_flush(const void *addr, unsig > * + prefix than a clflush + nop, and hence the prefix is added > instead > * of letting the alternative framework fill the gap by appending > nops. > */ > - alternative_io("ds; clflush %[p]", > - "data16 clflush %[p]", /* clflushopt */ > - X86_FEATURE_CLFLUSHOPT, > - /* no outputs */, > - [p] "m" (*(const char *)(addr))); > + alternative_input("ds; clflush %[p]",
Drop the ; as you're altering the line anyway? Acked-by: Andrew Cooper <[email protected]> However, switching to ds ds will avoid a trailing nop, so will be marginally better. > + "data16 clflush %[p]", /* clflushopt */ > + X86_FEATURE_CLFLUSHOPT, > + [p] "m" (*(const char *)(addr))); > } > > alternative_2("",
