On Wed, 4 Sep 2024, Andrew Cooper wrote: > Recent additions have undone prior tidying at the top of the file. > > Signed-off-by: Andrew Cooper <[email protected]>
Hi Andrew, I admit I don't understand the value and the meaning of the "Please tidy above here" comments. However, you got one just like this one committed with ea59e7d780d9 and then removed by 5f7606c048f7. It looks like they are useful to you. As you are the one doing the tiding, and given that you had one already before: Acked-by: Stefano Stabellini <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Stefano Stabellini <[email protected]> > CC: Julien Grall <[email protected]> > CC: Volodymyr Babchuk <[email protected]> > CC: Bertrand Marquis <[email protected]> > CC: Michal Orzel <[email protected]> > CC: Oleksii Kurochko <[email protected]> > CC: Shawn Anastasio <[email protected]> > --- > xen/include/xen/bitops.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h > index ed6b9ccc724f..6f8e36f1c755 100644 > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -210,6 +210,8 @@ static always_inline bool test_bit(int nr, const volatile > void *addr) > test_bit(nr, addr); \ > }) > > +/* --------------------- Please tidy above here --------------------- */ > + > static always_inline attr_const unsigned int ffs(unsigned int x) > { > if ( __builtin_constant_p(x) ) > -- > 2.39.2 >
