On 05/09/2024 4:47 pm, Jan Beulich wrote: > On 05.09.2024 17:45, Andrew Cooper wrote: >> On 05/09/2024 4:35 pm, Jan Beulich wrote: >>> On 05.09.2024 15:06, Andrew Cooper wrote: >>>> asm/config.h is included in every translation unit (via xen/config.h), >>>> while >>>> only a handful of functions actually interact with the trampoline. >>>> >>>> Move the infrastructure into its own header, and take the opportunity to >>>> document everything. >>>> >>>> Also change trampoline_realmode_entry() and wakeup_start() to be nocall >>>> functions, rather than char arrays. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Andrew Cooper <[email protected]> >>> Reviewed-by: Jan Beulich <[email protected]> >> Thanks. >> >>>> --- /dev/null >>>> +++ b/xen/arch/x86/include/asm/trampoline.h >>>> @@ -0,0 +1,98 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>>> +#ifndef XEN_ASM_TRAMPOLINE_H >>>> +#define XEN_ASM_TRAMPOLINE_H >>> Not exactly usual a guard name, but once the new naming scheme is finalized >>> most will need renaming anyway. >> What would you prefer? > X86_ASM_TRAMPOLINE_H would likely be closer to what we use elsewhere.
Fine. I'll adjust. ~Andrew
