>>> On 27.06.18 at 14:27, <[email protected]> wrote:
> Coverity complains at code which which performs a bitwise and with a constant
> that happens to be zero.  Both _PAGE_GNTTAB and PG_SH_enable may be 0
> depending on Kconfig settings.
> 
> Rearrange the C to test the constant first and short circuit the bitwise and.

Hmm, well, this makes the code look quite, ehem, interesting.
Normally such would seem a prime candidate for cleaning up,
especially without any comment attached. But anyway, if it
helps ...

> No functional change.
> 
> Signed-off-by: Andrew Cooper <[email protected]>

Acked-by: Jan Beulich <[email protected]>

Jan



_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to