On 29.08.2024 00:03, Andrew Cooper wrote: > All of the ffs()/fls() infrastructure is in fact (attr) const, because it > doesn't even read global state. This allows the compiler even more > flexibility to optimise. > > No functional change. > > Reported-by: Jan Beulich <[email protected]> > Signed-off-by: Andrew Cooper <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Stefano Stabellini <[email protected]> > CC: Julien Grall <[email protected]> > CC: Volodymyr Babchuk <[email protected]> > CC: Bertrand Marquis <[email protected]> > CC: Michal Orzel <[email protected]> > CC: Oleksii Kurochko <[email protected]> > CC: Shawn Anastasio <[email protected]> > > v2: > * New > --- > xen/include/xen/bitops.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
The various arch_* forms didn't have __pure and hence also don't gain attr_const presumably because we deem these attributes ineffectual for always-inline functions? On that basis Reviewed-by: Jan Beulich <[email protected]> Jan
