Re: [PATCH v1] automation: update xilinx tests to use expect

[Lira, Victor M]

On 8/28/2024 5:25 PM, Stefano Stabellini wrote:

  xilinx-smoke-dom0-x86_64-gcc-debug:
    extends: .xilinx-x86_64
+  variables:
+    TEST_TIMEOUT: 500

I think we need to add something similar for .xilinx-arm64
The timeout should be set in test.yaml otherwise we'll default to 1500

I will add the missing variable.

t TEST_LOGFILE="smoke.serial"
+mkfifo console
+sed 's/\r\+$//' < console &
+./automation/scripts/console.exp > console
+TEST_RESULT=$?
+sh /scratch/gitlab-runner/${TEST_BOARD}.sh 2
+exit ${TEST_RESULT}

Isn't this sufficient? Why do we need the fifo?

export TEST_PASS_MSG="${PASS_MSG}"
export TEST_CMD_START="cat ${SERIAL_DEV}"
export TEST_LOGFILE="smoke.serial"
./automation/scripts/console.exp | sed 's/\r//'
TEST_RESULT=$?
sh /scratch/gitlab-runner/${TEST_BOARD}.sh 2
exit ${TEST_RESULT}

In the line
        ./automation/scripts/console.exp | sed 's/\r//'

The exit status gets set to that of "sed" instead of "console.exp", and it could
produce a false result. This was one way to achieve the result while avoiding 
bash-isms.


Victor