On 08.08.2024 14:09, Ayan Kumar Halder wrote:
> @@ -58,9 +58,13 @@ config PADDR_BITS
> default 40 if ARM_PA_BITS_40
> default 48 if ARM_64
>
> +config HAS_VMAP
> + def_bool y
With this being always enabled, ...
> config MMU
> def_bool y
> select HAS_PMAP
> + select HAS_VMAP
.. what use is this?
> --- a/xen/include/xen/vmap.h
> +++ b/xen/include/xen/vmap.h
> @@ -141,7 +141,9 @@ void *arch_vmap_virt_end(void);
> /* Initialises the VMAP_DEFAULT virtual range */
> static inline void vm_init(void)
> {
> +#ifdef CONFIG_MMU
> vm_init_type(VMAP_DEFAULT, (void *)VMAP_VIRT_START,
> arch_vmap_virt_end());
> +#endif
> }
What about non-Arm, which all have MMUs but no corresponding Kconfig
setting? And why is this not CONFIG_HAS_VMAP anyway (with HAS_VMAP
properly moved to common/Kconfig, where e.g. HAS_PMAP also lives,
and then unconditionally selected by all other architectures)?
Jan
