On 23.07.2024 10:15, Alessandro Zucchelli wrote: > From: Simone Ballarin <[email protected]> > > Amend inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of the headers > (comments are permitted anywhere) and the #if directive cannot > be used for other checks. > > Mechanical change. > > Signed-off-by: Simone Ballarin <[email protected]> > Signed-off-by: Maria Celeste Cesario <[email protected]> > Acked-by: Julien Grall <[email protected]> > Reviewed-by: Stefano Stabellini <[email protected]> > Signed-off-by: Nicola Vetrini <[email protected]> > Signed-off-by: Alessandro Zucchelli <[email protected]>
Provided the description of the scheme itself goes in first: Acked-by: Jan Beulich <[email protected]> > --- > Changes in v5: > - edit inclusion guards, according to the feedback received Given how exactly the guards look like is the main aspect here, I question the retaining of earlier R-b with changes like what is said here. Jan
