On 12/07/2024 12:39 pm, Oleksii wrote: > On Thu, 2024-07-11 at 12:15 +0100, Andrew Cooper wrote: >> For starters, they're slightly smaller: >> >> $ docker image list <snip> >> registry.gitlab.com/xen-project/xen/debian 12-riscv64 >> 772MB >> registry.gitlab.com/xen-project/xen/debian 11-riscv64 >> 422MB > Do we really need both 11-riscv64 and 12-riscv64?
Need? No, not strictly. Want? Yes, absolutely. You always want at least 2 different toolchains worth of testing, or what you will find happens is that you end up accidentally depending on a quirk of the single compiler your using, and that you discover this at some point in the future, rather than now(ish) when CI says no. At the moment, the RISC-V builds are very trivial and quick, so it makes a lot of sense to have a second toolchain. Before too much longer, you'll want to get Clang working too. > Generally this patch LGTM: Reviewed-by: Oleksii Kurochko > <[email protected]> Thanks. ~Andrew
