On 01.07.2024 14:03, Sergiy Kibrik wrote: > Separate ACPI driver from generic initialization cpufreq code. > This way acpi-cpufreq can become optional in the future and be disabled > from non-Intel builds. > > Other than acpi_register_driver() helper added and clean up a list of > included headers no changes to code were introduced.
And perhaps that's okay despite the many style violations that you move around. However, acpi_register_driver() is too generic a name. How about acpi_cpufreq_register() (not not have it grow overly long)? Plus > --- /dev/null > +++ b/xen/arch/x86/acpi/cpufreq/acpi.c > @@ -0,0 +1,622 @@ > +/* > + * cpufreq.c - ACPI Processor P-States Driver ($Revision: 1.4 $) > + * > + * Copyright (C) 2001, 2002 Andy Grover <[email protected]> > + * Copyright (C) 2001, 2002 Paul Diefenbaugh <[email protected]> > + * Copyright (C) 2002 - 2004 Dominik Brodowski <[email protected]> > + * Copyright (C) 2006 Denis Sadykov <[email protected]> > + * > + * Feb 2008 - Liu Jinsong <[email protected]> > + * porting acpi-cpufreq.c from Linux 2.6.23 to Xen hypervisor > + * > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or (at > + * your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; If not, see <http://www.gnu.org/licenses/>. > + * > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + */ ... I expect this should be transformed into an SPDX line. I expect the one in cpufreq.c wasn't picked up when the conversion was done because it doesn't fully match whatever pattern was looked for at the time. Jan
