On 11.06.2024 11:34, Petr Beneš wrote: > On Tue, Jun 11, 2024 at 11:14 AM Jan Beulich <[email protected]> wrote: >> On 11.06.2024 10:00, Petr Beneš wrote: >>> On Tue, Jun 11, 2024 at 8:41 AM Jan Beulich <[email protected]> wrote: >>>> On 10.06.2024 19:10, Petr Beneš wrote: >>>>> From: Petr Beneš <[email protected]> >>>>> >>>>> Encapsulate the altp2m options within a struct. This change is preparatory >>>>> and sets the groundwork for introducing additional parameter in subsequent >>>>> commit. >>>>> >>>>> Signed-off-by: Petr Beneš <[email protected]> >>>>> Acked-by: Julien Grall <[email protected]> # arm >>>>> Reviewed-by: Jan Beulich <[email protected]> # hypervisor >>>> >>>> Looks like you lost Christian's ack for ... >>>> >>>>> --- >>>>> tools/libs/light/libxl_create.c | 6 +++--- >>>>> tools/ocaml/libs/xc/xenctrl_stubs.c | 4 +++- >>>> >>>> ... the adjustment of this file? >>> >>> In the cover email, Christian only acked: >>> >>>> tools/ocaml/libs/xc/xenctrl.ml | 2 + >>>> tools/ocaml/libs/xc/xenctrl.mli | 2 + >>>> tools/ocaml/libs/xc/xenctrl_stubs.c | 40 +++++++--- >> >> Right, but above I was talking about the last of these three files. >> >> Jan > > Ouch. It didn't occur to me that Ack on cover email acks each of the > files in every separate patch. My thinking was it acks only the > patches where those three are together. Anyway, it makes sense. I'll > resend v7.
Well, no need to just for this. Yet if a v7 turns out necessary, please make sure you have the ack recorded. Jan
