On 06.06.2024 13:04, Sergiy Kibrik wrote: > --- a/xen/arch/x86/spec_ctrl.c > +++ b/xen/arch/x86/spec_ctrl.c > @@ -116,8 +116,10 @@ static int __init cf_check parse_spec_ctrl(const char *s) > if ( opt_pv_l1tf_domu < 0 ) > opt_pv_l1tf_domu = 0; > > +#ifdef CONFIG_INTEL > if ( opt_tsx == -1 ) > opt_tsx = -3; > +#endif
Personally I prefer using the direct check in such cases, rather one on a prereq symbol. I.e. "#ifndef opt_tsx" both here and below. Other maintainers may have a different view, though, so I won't insist unless at least one of them shares this perspective with me. Other than this: Looks largely okay to me. Jan
