On 30/05/2024 6:16 pm, Oleksii K. wrote: > On Thu, 2024-05-30 at 17:47 +0100, Andrew Cooper wrote: >> On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: >>> diff --git a/README b/README >>> index c8a108449e..30da5ff9c0 100644 >>> --- a/README >>> +++ b/README >>> @@ -48,6 +48,10 @@ provided by your OS distributor: >>> - For ARM 64-bit: >>> - GCC 5.1 or later >>> - GNU Binutils 2.24 or later >>> + - For RISC-V 64-bit: >>> + - GCC 12.2 or later >>> + - GNU Binutils 2.39 or later >>> + Older GCC and GNU Binutils would work, but this is not a >>> guarantee. >> This sentence isn't appropriate to live here. >> >> The commit message saying "this is what we run in CI" is perfectly >> good >> enough. >> >> With this dropped, Reviewed-by: Andrew Cooper >> <[email protected]>. Can fix on commt. > I am okay with dropping this sentence, but someone ( unfortunately I > don't remember who Jan? Julien? ) requested it, and I think it would be > nice to hear their opinion before doing so.
It's line noise, and literally a redundant statement. The same is true of every other line in the file, and we don't write it because that would be incredibly stupid. Anyone who wants to see why this was chosen can read the commit message. ~Andrew
