On 26.04.2024 18:08, Andrew Cooper wrote: > Some features need accumulating rather than intersecting to make migration > safe. Introduce the new '|' attribute for this purpose. > > Right now, it's only used by the Xapi toolstack, but it will be used by > xl/libxl when the full policy-object work is complete, and until then it's > still a useful hint for hand-crafted cpuid= lines in vm.cfg files. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> The one feature you don't annotate such that I'm not entirely sure about is NO_FPU_SEL: On one hand it tells code not to rely on / use the selector fields in FPU state. That would be a reason to mark it here. Otoh the specific behavior of storing zero of course won't occur on older hardware, being an argument for having things the way you do. Perhaps a sentence or two could be added to the description? Jan
