On 04.04.2024 13:38, Sergiy Kibrik wrote: > Separate Intel nonfatal MCE initialization code from generic MCE code, the > same > way it is done for AMD code. This is to be able to later make intel/amd MCE > code optional in the build. > > Also clean up unused includes. > > No functional change intended. > > Signed-off-by: Sergiy Kibrik <[email protected]> > --- > xen/arch/x86/cpu/mcheck/Makefile | 1 + > xen/arch/x86/cpu/mcheck/intel_nonfatal.c | 83 ++++++++++++++++++++++++
Like elsewhere, can we please uses dashes in favor of underscores in new files' names? > --- /dev/null > +++ b/xen/arch/x86/cpu/mcheck/intel_nonfatal.c > @@ -0,0 +1,83 @@ > +/* > + * Non Fatal Machine Check Exception Reporting > + * > + * (C) Copyright 2002 Dave Jones. <[email protected]> > + * > + * This file contains routines to check for non-fatal MCEs every 15s > + * Nit: This almost blank line wants dropping. Furthermore the whole file, no longer having a direct Linux equivalent, imo wants converting to Xen code style right for its introduction. Jan
