On 2024-04-04 06:09, Jan Beulich wrote:
On 27.03.2024 22:50, Jason Andryuk wrote:
@@ -36,6 +35,11 @@ static xc_evtchn_port_or_error_t console_evtchn;
  static xentoollog_level minmsglevel = XTL_PROGRESS;
  static void *logger;
+static inline uint64_t mb_to_bytes(int mem)
+{
+       return (uint64_t)mem << 20;
+}

While committing I noticed tab indentation here, which looked to be in
conflict with ...

  static struct option options[] = {
      { "kernel", 1, NULL, 'k' },
      { "memory", 1, NULL, 'm' },
@@ -76,8 +80,8 @@ static int build(xc_interface *xch)
      int rv, xs_fd;
      struct xc_dom_image *dom = NULL;
      int limit_kb = (maxmem ? : memory) * 1024 + X86_HVM_NR_SPECIAL_PAGES * 4;
-    uint64_t mem_size = MB(memory);
-    uint64_t max_size = MB(maxmem ? : memory);
+    uint64_t mem_size = mb_to_bytes(memory);
+    uint64_t max_size = mb_to_bytes(maxmem ? : memory);
      struct e820entry e820[3];
      struct xen_domctl_createdomain config = {
          .ssidref = SECINITSID_DOMU,

... everything else in the file. Hence I took the liberty to adjust this.

Thank you for catching that and fixing it up.

-Jason

Reply via email to