Hi Luca, On 12/03/2024 14:03, Luca Fancellu wrote: > > > From: Penny Zheng <[email protected]> > > Putting overlap and overflow checking in the loop is causing repetitive > operation, so this commit extracts both checking outside the loop. > > Signed-off-by: Penny Zheng <[email protected]> > Signed-off-by: Luca Fancellu <[email protected]> > --- > v1: > - Rework of > https://patchwork.kernel.org/project/xen-devel/patch/[email protected]/ > - use strncmp to match the branch above I don't understand why we need strncmp if we already validated that shm_id is NULL terminated within MAX_SHM_ID_LENGTH at the beginning of the function with strnlen.
Other than that: Reviewed-by: Michal Orzel <[email protected]> ~Michal
