On 13.03.2024 18:27, Andrew Cooper wrote:
> --- a/xen/arch/x86/include/asm/bitops.h
> +++ b/xen/arch/x86/include/asm/bitops.h
> @@ -401,18 +401,6 @@ static always_inline unsigned int __scanbit(unsigned
> long val, unsigned int max)
> r__; \
> })
>
> -/**
> - * find_first_set_bit - find the first set bit in @word
> - * @word: the word to search
> - *
> - * Returns the bit-number of the first set bit. The input must *not* be zero.
> - */
> -static inline unsigned int find_first_set_bit(unsigned long word)
> -{
> - asm ( "rep; bsf %1,%0" : "=r" (word) : "rm" (word) );
> - return (unsigned int)word;
> -}
And you think it's okay to no longer use TZCNT like this when available,
where the output doesn't have to have its value set up front?
Jan
