On 13.03.2024 14:54, Vaishali Thakkar wrote: > On 3/12/24 09:05, Jan Beulich wrote: >> On 11.03.2024 13:40, Vaishali Thakkar wrote: >>> While sev and sev_es bits are not yet enabled in xen, >>> including their status in the VMCB dump could be >>> informational.Therefore, print it via svmdebug. >> >> Yet there are more bits there. I'm okay with leaving off printing of >> them here, but it wants clarifying why some are printed and some are >> not. > > Well, the idea is to print the bits that are either enabled or has WIP > to enable them. (e.g. sev and sev_es) I didn't include other bits as > I'm not sure if there is any WIP to enable them. Particularly including > sev and sev_es is useful for us while working on the enablement of it. > > Does a commit log like the following makes it clear for you? > > " Currently only raw _np_ctrl is being printed. It can > be informational to know about which particular bits > are enabled. So, this commit adds the bit-by-bit decode > for np, sev and sev_es bits. > > Note that while only np is enabled in certain scenarios > at the moment, work for enabling sev and sev_es is in > progress. And it's useful to have this information as > part of svmdebug. "
I think that's sufficient, yes. Jan
