On 06.03.2024 15:57, Anthony PERARD wrote:
> On Thu, Dec 07, 2023 at 11:48:12AM +0100, Jan Beulich wrote:
>> Passing in $(CFLAGS) means also requesting inclusion of certain headers
>> (via -include command line options). That's particularly xen/config.h,
>> which in turn requires generated/autoconf.h. This has not caused any
>> problems so far only because arch.mk is processed twice, and the missing
>
> The first pass is ignore because "include/config/auto.conf" is missing,
> and generating that will also generates "generated/autoconf.h" I think.
> So result don't matter, and make restart from scratch once "auto.conf"
> is generated.
>
>> header on the 1st pass would be there on the 2nd. Having added an
>> inclusion of asm/asm-macros.h to x86'es asm/config.h, the 2nd pass then
>
> I don't see asm-macros.h been included in asm/config.h, is this
> in a pending patch?
Yes. I hoped to get this across with "Having added ...".
>> also fails on an initial, pristine build.
>>
>> As per dd40177c1bc8 ("x86-64/EFI: add CFLAGS to check compile") dropping
>> the use of $(CFLAGS) altogether isn't an option, though. Hence remove
>> the problematic options only.
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> In any case, patch looks fine:
> Reviewed-by: Anthony PERARD <[email protected]>
Thanks.
Jan
