On 06.02.2024 02:20, George Dunlap wrote:
> --- a/xen/arch/x86/include/asm/hvm/hvm.h
> +++ b/xen/arch/x86/include/asm/hvm/hvm.h
> @@ -86,20 +86,19 @@ struct hvm_vcpu_nonreg_state {
> struct hvm_function_table {
> const char *name;
>
> - /* Support Hardware-Assisted Paging? */
> - bool hap_supported;
> -
> - /* Necessary hardware support for alternate p2m's? */
> - bool altp2m_supported;
> - bool singlestep_supported;
> -
> - /* Hardware virtual interrupt delivery enable? */
> - bool virtual_intr_delivery_enabled;
> -
> struct {
> /* Indicate HAP capabilities. */
> - bool hap_superpage_1gb:1,
> - hap_superpage_2mb:1;
> + bool hap:1,
> + hap_superpage_1gb:1,
> + hap_superpage_2mb:1,
> +
> + /* Altp2m capabilities */
> + altp2m:1,
> + singlestep:1,
> +
> + /* Hardware virtual interrupt delivery enable? */
> + virtual_intr_delivery;
> +
> } caps;
Nit (spotted only while looking at patch 6): You're adding a stray blank
line at the end of the structure. Further I expect virtual_intr_delivery
would also want to be just a single bit?
Jan
