Hi Julien,
> On 13/02/2024 17:40, Julien Grall wrote: > > Hi Oleksii, > > > > On 09/02/2024 18:00, Oleksii Kurochko wrote: > > > The header is shared between several archs so it is > > > moved to asm-generic. > > > > > > Switch partly Arm and PPC to asm-generic/monitor.h and only > > > arch_monitor_get_capabilities() left in arch-specific/monitor.h. > > > > > > Signed-off-by: Oleksii Kurochko <[email protected]> > > > Acked-by: Jan Beulich <[email protected]> > > > Acked-by: Tamas K Lengyel <[email protected]> > > > --- > > > Changes in V8: > > > - Add Acked-by: Tamas K Lengyel <[email protected]> > > > --- > > > Changes in V7: > > > - Drop definition of arch_monitor_domctl_event for PPC. > > > - define arch_monitor_domctl_event in asm-generic/monitor.h. > > > - add "define HAS_ARCH_MONITOR_DOMCTL_EVENT" in > > > arm/.../monitor.h as > > > it has arch specific implementation. > > > --- > > > Changes in V6: > > > - Rebase only. > > > --- > > > Changes in V5: > > > - Switched partly Arm and PPC to asm-generic monitor.h only > > > arch_monitor_get_capabilities() left in arch- > > > specific/monitor.h. > > > - Updated the commit message. > > > --- > > > Changes in V4: > > > - Removed the double blank line. > > > - Added Acked-by: Jan Beulich <[email protected]>. > > > - Update the commit message > > > --- > > > Changes in V3: > > > - Use forward-declaration of struct domain instead of " > > > #include > > > <xen/sched.h> ". > > > - Add ' include <xen/errno.h> ' > > > - Drop PPC's monitor.h. > > > --- > > > Changes in V2: > > > - remove inclusion of "+#include <public/domctl.h>" > > > - add "struct xen_domctl_monitor_op;" > > > - remove one of SPDX tags. > > > --- > > > xen/arch/arm/include/asm/monitor.h | 25 +----------- > > > xen/arch/ppc/include/asm/monitor.h | 28 +------------ > > > > Looking at MAINTAINERS, monitor.h was covered by "VM EVENT, MEM > > ACCESS > > and MONITOR". As you move to ... > > > > > xen/arch/ppc/stubs.c | 8 ---- > > > xen/include/asm-generic/monitor.h | 64 > > > ++++++++++++++++++++++++++++++ > > > > ... asm-generic/, I believe it will now fall under "THE REST". So I > > think MAINTAINERS needs to be updated to also cover asm- > > generic/monitor.h. > > > > Looking at what was already committed, I think asm- > > generic/vm_event.h > > should also be added in MAINTAINERS. Can you send a separate patch > > for > > that? > > Oh, I just noticed that we have the following entry: > > xen/include/*/monitor.h > > So the header is already covered. Sorry for the noise. > > As the code is falling under the "VM EVENT..." subsystem, then > Tamas's > acked is technically sufficient for this patch (even for the PPC > change). > > But just in case you need one for Arm: > > Acked-by: Julien Grall <[email protected]> Thanks. ~ Oleksii
