> On Thu, Feb 8, 2024 at 10:14 AM Christian Lindig <[email protected]> > wrote: > > > On 7 Feb 2024, at 22:04, Petr Beneš <[email protected]> wrote: > > > > > > Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > > vm.cfg configuration, correcting an oversight from its initial introduction. > > > > Signed-off-by: Petr Beneš <[email protected]> > > Acked-by: Christian Lindig <[email protected]> > > This looks correct from an OCaml perspective. Why was the new field added in > the middle of the record type domctl_create_config and thus forcing changes > to the index of fields coming later in the record versus just appending the > new field to the record type? >
To match the position of the field inside of xen_domctl_createdomain. P.
