On 07 Feb 2024 16:44, Anthony PERARD wrote:
No worries, and your patch was reviewed so you didn't failed to the
strict minimum ;-).
Ahah, true, just felt a bit stupid ! Thanks, and also for the gdb pointers.
But sorry for nooby "non-rebased/non-squashed" v2, fixed now ;)
I have a "display dom id column" in the pipes, ready to send [...]
That TODO file is 18 year old, and never been touch since. I don't
know how relevant it is. As for wanted features, I'm not aware of
such list.
TODO is 18 y/o, but some ideas are still nice to have ! At least
for me ;)
Like adding a "domain id" column, I ask beforehand because it will
change the default, expected display of xentop in "batch mode", and it
will annoy everyone relying on a constant output. Should I worry ?
To preserve old behaviour, I'd have to add the possibility of
displaying/hiding columns -before- adding the "dom_id" column, to then
make it hidden by default.
I'm slightly worried about adding domain management, what if someone
hit the wrong key and kill a domain when they just wanted to do
something else, but I guess we can make domain management work more
or less safely. In any case, any feature is welcome.
I share your concerns re. domain management, we've all messed up at
least once with the wrong term/window, could be a real PITA !
Some have seen a ":q" followed by "oops" in XenDevel recently :)
I'd create a "*M*anage domain" bottom item, as a prompt, asking
the action and domain, like "pause domu1", "r domu2","s 42" :
Manage domain (p/r/s/d <Domain>): _
Manage domain (p/r/s/d <Domain>): pause domu1_
Manage domain (p/r/s/d <Domain>): s 42_
I think it's practical -and- safe enough, even the shortest form.
Would that be a good starting point ?
((( Rest of the mail is a list of alternatives, but requiring the
ability to select a domain/line :
1) Select the domain, press <M>, enter the action in a prompt :
*P*ause/unpause,*R*estart,*S*hutdown,*D*estroy domain 'mydomu' ? _
2) Like (2) but add a confirmation step :
To pause 'mydomu', type [y/yes/pause/dom_name/etc]: _
This confirm step could be user-chosen with a cmdline option, like :
-c/-m [no-confirm/y/yes/action-name/dom-id/dom-name]
3) Arrow-keys and menu driven: select the domain <Enter> select the
action <Enter> (could also be used to display more domain info/config)
)))
--
++
zithro / Cyril
