On 07.02.2024 15:31, Andrew Cooper wrote: > On 07/02/2024 2:03 pm, Jan Beulich wrote: >> This aspect is simply meaningless for this component. >> >> Signed-off-by: Jan Beulich <[email protected]> > > In principle Acked-by: Andrew Cooper <[email protected]>, but > >> >> --- a/tools/firmware/hvmloader/Makefile >> +++ b/tools/firmware/hvmloader/Makefile >> @@ -20,6 +20,8 @@ >> XEN_ROOT = $(CURDIR)/../../.. >> include $(XEN_ROOT)/tools/firmware/Rules.mk >> >> +ld-option = $(shell if $(LD) -v $(1) >/dev/null 2>&1; then echo y; else >> echo n; fi) > > The root config.mk has cc-option, and one opencoded ld-option for > handling build-id's. > > This ought to live there, and ideally clean up the opencoded use while > at at.
Well, that's what I first meant to do. But: xen/scripts/Kconfig.include has a different ld-option, and I didn't want to get into the business of having two fight each other. Jan
