On 02.02.2024 16:16, Simone Ballarin wrote:
> Rule 13.1: Initializer lists shall not contain persistent side effects
> 
> The assignment operation in:
> 
> .irq = rc = uart->irq,
> 
> is a persistent side effect in a struct initializer list.
> 
> This patch assigns rc separately outside the structure.
> 
> No functional change.
> 
> Signed-off-by: Simone Ballarin <[email protected]>
> Signed-off-by: Maria Celeste Cesario  <[email protected]>

Acked-by: Jan Beulich <[email protected]>

Nevertheless I think this would have benefited from limiting rc's
scope.

Jan

Reply via email to