On 24/01/2024 1:07 am, Stefano Stabellini wrote: >> I agree with Jan that we could reuse >> xendevicemodel_inject_msi by assuing that PCI BDF zero is invalid.
I've already explained why that will break future x86. (See the other thread off this patch for specifics). When we add vIOMMUs to guests, we *must* have correct source ids. 0 is ambiguous, so not safe to reuse. Allocating a new subop now is the only way to not shoot in the foot later. ~Andrew
